Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data, app): fix deck view diff between deck and labware de… #14143

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 7, 2023

Overview

close RQA-2008

#14127 (comment)

[before]
IMG_4577

[after]
Screenshot 2023-12-07 at 3 33 19 PM

close RQO-2008

Test Plan

Changelog

Review requests

Risk assessment

low

@koji koji requested review from brenthagen and a team December 7, 2023 20:38
@koji koji marked this pull request as ready for review December 7, 2023 20:38
@koji koji requested a review from a team as a code owner December 7, 2023 20:38
@koji koji removed the request for review from a team December 7, 2023 20:38
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #14143 (fdd69c8) into chore_release-7.1.0 (7e765eb) will decrease coverage by 0.01%.
Report is 1 commits behind head on chore_release-7.1.0.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14143      +/-   ##
=======================================================
- Coverage                70.44%   70.44%   -0.01%     
=======================================================
  Files                     2512     2512              
  Lines                    71197    71197              
  Branches                  8962     8963       +1     
=======================================================
- Hits                     50158    50157       -1     
  Misses                   18849    18849              
- Partials                  2190     2191       +1     
Flag Coverage Δ
app 67.63% <0.00%> (-0.01%) ⬇️
protocol-designer 44.99% <ø> (ø)
shared-data 75.02% <ø> (ø)
step-generation 86.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../Devices/ProtocolRun/utils/getLabwareRenderInfo.ts 68.18% <0.00%> (-4.55%) ⬇️

Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@sfoster1 sfoster1 merged commit 281f88c into chore_release-7.1.0 Dec 7, 2023
45 of 46 checks passed
@sfoster1 sfoster1 deleted the fix_data-type-diff branch December 7, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants