Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data): add slot transforms for A3 for heater-shaker and temp module v2 #14235

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

jbleon95
Copy link
Contributor

Overview

Fixes RQA-2136.

Once upon a time, modules could not go on slot A3 since that's where the fixed trash was. Then we set the trash free to roam around the deck, allowing that slot to be used for a heater-shaker or temperature module. Unfortunately, we never accounted for this in the module definition and left the A3 affine slot transformation empty. This caused large LPC offsets for labware on modules and completely broke module calibration, which can't use offsets.

Now this has been fixed by judicious copy and pasting of the column 3 transforms for slot A3 as well.

Test Plan

Tested calibrating temperature module on A3, both without this fix and with this fix to ensure that it worked as expected (it did).

Changelog

  • added a slot A3 affine transform matrix to slotTransforms for temperatureModuleV2 and heaterShakerModuleV1

Review requests

Risk assessment

Low, this fixes a clearly missing piece of supporting modules on A3. The only danger is using an old adjusted offset now that the position has been fixed, since that will cause the pipette to go too far down.

@jbleon95 jbleon95 requested a review from a team as a code owner December 18, 2023 19:42
@jbleon95 jbleon95 requested review from b-cooper, sfoster1 and sanni-t and removed request for a team and b-cooper December 18, 2023 19:42
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #14235 (26446bd) into chore_release-7.1.0 (d2e9f57) will not change coverage.
Report is 2 commits behind head on chore_release-7.1.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.1.0   #14235   +/-   ##
====================================================
  Coverage                70.38%   70.38%           
====================================================
  Files                     2513     2513           
  Lines                    71332    71332           
  Branches                  9030     9030           
====================================================
  Hits                     50210    50210           
  Misses                   18917    18917           
  Partials                  2205     2205           
Flag Coverage Δ
app 67.49% <ø> (ø)
protocol-designer 45.01% <ø> (ø)
shared-data 75.04% <ø> (ø)
step-generation 86.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray, thank you!

@jbleon95 jbleon95 merged commit 0716cad into chore_release-7.1.0 Dec 18, 2023
58 checks passed
@jbleon95 jbleon95 deleted the transform_modules_on_a3 branch December 18, 2023 19:57
ncdiehl11 pushed a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants