Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): disable external links from opening in ODD #14472

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

shlokamin
Copy link
Member

Overview

This PR disables the browser layer from opening up new windows on the ODD.

closes RQA-2318

Changelog

  • Disable external links from opening in ODD

Review requests

Open up release notes on the ODD and press one of the links. Nothing should happen.

Risk assessment

Low

@shlokamin shlokamin marked this pull request as ready for review February 12, 2024 14:31
@shlokamin shlokamin requested a review from a team as a code owner February 12, 2024 14:31
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (416d823) 67.78% compared to head (bd6fbf2) 67.80%.
Report is 5 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14472      +/-   ##
=======================================================
+ Coverage                67.78%   67.80%   +0.01%     
=======================================================
  Files                     2519     2519              
  Lines                    72011    72043      +32     
  Branches                  9263     9279      +16     
=======================================================
+ Hits                     48812    48846      +34     
+ Misses                   20991    20988       -3     
- Partials                  2208     2209       +1     
Flag Coverage Δ
app 64.68% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app-shell-odd/src/ui.ts 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing
Once fix js-checks, this should be good to go.

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with passing CI!

@shlokamin
Copy link
Member Author

Once fix js-checks, this should be good to go.

oops thanks for fixing the linting issue @koji !

@shlokamin shlokamin merged commit fe3d91d into chore_release-7.2.0 Feb 14, 2024
21 of 22 checks passed
@koji koji deleted the odd_open_external_links_in_browser branch April 17, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants