Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix center aligned app release notes #14511

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Feb 16, 2024

Closes RQA-2360

Overview

This one is funny. Several months ago, for some reason I don't understand, I tried to CSS text-align: center the update modal text. However, I made a typo, textalign, which kept the text aligned properly.

Present day (well, a few days ago). @koji was nice enough to notice the typo and fixed it while updating colors. This caused the dormant text-align bug to appear.

The fix - we don't need text-align here :)

Before

Screenshot 2024-02-15 at 2 49 16 PM

After

Screenshot 2024-02-16 at 8 41 11 AM

Test Plan

  • Here is a special build of the app that is 7.2.0-alpha.2 + this commit.
  • Launch the app, enable the alpha update channel, and try to update the app. Note that the release notes are properly left-aligned now.

Changelog

  • App release notes are no longer center-aligned.

Risk assessment

low

@mjhuff mjhuff requested a review from a team as a code owner February 16, 2024 13:48
@mjhuff mjhuff requested review from brenthagen and a team and removed request for a team February 16, 2024 13:48
@mjhuff mjhuff changed the base branch from edge to chore_release-7.2.0 February 16, 2024 13:48
@mjhuff mjhuff requested a review from ecormany February 16, 2024 13:48
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c19564) 67.78% compared to head (7037a24) 67.72%.
Report is 17 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14511      +/-   ##
=======================================================
- Coverage                67.78%   67.72%   -0.06%     
=======================================================
  Files                     2519     2519              
  Lines                    72011    72260     +249     
  Branches                  9263     9364     +101     
=======================================================
+ Hits                     48812    48941     +129     
- Misses                   20991    21106     +115     
- Partials                  2208     2213       +5     
Flag Coverage Δ
app 64.41% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/src/organisms/UpdateAppModal/index.tsx 89.47% <ø> (ø)

... and 11 files with indirect coverage changes

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love the bug lore 😆, thanks for fixing!

@mjhuff mjhuff merged commit 6d12cb5 into chore_release-7.2.0 Feb 16, 2024
39 checks passed
@mjhuff mjhuff deleted the app_fix-center-aligned-update-text branch February 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants