Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): fix robot IP connection text input #14558

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

ncdiehl11
Copy link
Collaborator

closes RQA-2350

Overview

provide padding in form for connecting to robot via IP address

Test Plan

  • navigate to app settings > 'Connect to a Robot via IP Address'
  • click into IP form
  • observe cursor position
Screen Shot 2024-02-27 at 3 41 47 PM

Risk assessment

low

@ncdiehl11 ncdiehl11 marked this pull request as ready for review February 27, 2024 20:52
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner February 27, 2024 20:52
@ncdiehl11 ncdiehl11 requested review from b-cooper and removed request for a team February 27, 2024 20:52
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.74%. Comparing base (6b9344f) to head (7a8836a).
Report is 2 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.2.0   #14558   +/-   ##
====================================================
  Coverage                67.74%   67.74%           
====================================================
  Files                     2521     2521           
  Lines                    72201    72201           
  Branches                  9293     9293           
====================================================
  Hits                     48916    48916           
  Misses                   21064    21064           
  Partials                  2221     2221           
Flag Coverage Δ
app 64.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...src/organisms/AppSettings/ManualIpHostnameForm.tsx 92.00% <ø> (ø)

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this!

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like Design plans to unify our InputField components in the near future, so a one-off fix for this is fine!

@ncdiehl11 ncdiehl11 merged commit 795bda5 into chore_release-7.2.0 Feb 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants