Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Change the camera device to /dev/camera2 #14790

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Apr 3, 2024

Overview

We updated the Linux Kernel recently which has changed the camera device from /dev/video0 to /dev/video2, so lets change it here. This pull request pertains to Opentrons/oe-core#140.

Closes: EXEC-354

Test Plan

  • Make sure we can take a picture via /camera/picture endpoint.

Changelog

  • set the camera device to /dev/video2 when taking a picture

Review requests

Risk assessment

@vegano1 vegano1 requested review from a team as code owners April 3, 2024 15:22
@vegano1 vegano1 requested review from mjhuff and removed request for a team April 3, 2024 15:22
@vegano1
Copy link
Contributor Author

vegano1 commented Apr 3, 2024

curl -X POST --header "opentrons-version: 3" 127.0.0.1:31950/camera/picture --output "picture1.jpg"

picture1

@sfoster1 sfoster1 changed the base branch from edge to chore_release-7.2.2 April 3, 2024 15:24
@vegano1 vegano1 requested a review from sfoster1 April 3, 2024 15:25
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.56%. Comparing base (4bf9073) to head (9c63b50).

❗ Current head 9c63b50 differs from pull request most recent head d39c938. Consider uploading reports for the commit d39c938 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.2.2   #14790   +/-   ##
====================================================
  Coverage                67.56%   67.56%           
====================================================
  Files                     2521     2521           
  Lines                    72251    72251           
  Branches                  9311     9311           
====================================================
  Hits                     48815    48815           
  Misses                   21240    21240           
  Partials                  2196     2196           
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/src/opentrons/system/camera.py 0.00% <ø> (ø)

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sfoster1 sfoster1 merged commit 8f2c5e3 into chore_release-7.2.2 Apr 3, 2024
22 checks passed
@sfoster1 sfoster1 deleted the EXEC-354-fix-camera-device branch April 3, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants