Remove opentrons- prefix from mDNS advertisements and /health name

[umbhau]

Expected Behavior

• API should be returning robot ID from config (so that the App can display it)

Observed Behavior

• API is returning longer string name

Steps to recreate

• Connect to any robot
• Observe 'Robot Name' in 'Information' card is reported as:
  "opentrons-OT2P20180314A02", or "Opentrons on Brians-MacBook-Pro-2" (@mcous edit: this is a a spoofed name from a dev tool and not relevant)
  rather than as the serial number/id:
  "OT2P20180314A02"

[umbhau]

Not very familiar with how id/name (?) are configured as data / returned via API; filing this bug on behalf of @andySigler who reports the following:

"the #1 issue the SZ team kept reminding me of is that the App doesn't show the robot name as an ID anymore. Now it shows the random English words resin first assigns it like Opentrons-still-paper, but no longer shows the ID they then rename it to like OT2P20180812A01. They say this is super duper annoying because they don't know which robot is which"

With the following clarification from @mcous:

"At some point the API appears to have stopped being able to pick up the ID from configuration and so it’s reporting its name as the words name to the app, which is what gets displayed"

@btmorr @Laura-Danielle I can do further investigation, but suspect you might already be aware of this, if not the issue it's causing in Shenzhen.

[mcous]

@umbhau @andySigler in terms of the factory issue:

...Now it shows the random English words resin first assigns it like Opentrons-still-paper, but no longer shows the ID they then rename it to like OT2P20180812A01...

I've just done some testing and this appears to be a factory process issue, not a problem with the API. Removed bug tag accordingly and re-scoped this ticket to be a feature request to remove the opentrons- name prefix that the API has been adding to the name for no-longer-relevant technical reasons.

@andySigler and I will be following up on the factory process stuff outside of GH.

[mcous]

Removing the opentrons- name prefix is a breaking change that will prevent older versions of the app from finding newer versions of the robot (that don't have the prefix) on the network

[btmorr]

@mcous Should we close this in light of #2357? Seems like this is probably something we're not going to change

[mcous]

@btmorr I would prefer we don't add opentrons- automatically to the advertised name unless we have a good reason to do so.

@sfoster1 in this comment you mentioned something about advertising our capabilities more specifically than tcp; do you think that's something likely to ship with the new system?

[mcous]

This behavior has been changed in the new buildroot-based system; closing