Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3) Use Setuptools conventions in API installation #370

Closed
3 tasks done
astaff opened this issue Oct 5, 2017 · 3 comments
Closed
3 tasks done

(v3) Use Setuptools conventions in API installation #370

astaff opened this issue Oct 5, 2017 · 3 comments
Labels
api Affects the `api` project chore

Comments

@astaff
Copy link
Contributor

astaff commented Oct 5, 2017

overview

Let's use pip install . that uses setup.py to install the package and it's dependencies required to run the API and keep build/ci dependencies in requrements.txt. Refer to #347 for further discussion

  • Chore
  • API, Docker, Makefiles
  • Version 3.x

steps to reproduce problem

This results in duplicating run dependencies in setup.py and requirements.txt to make non-compliant installation calls work.

@mcous mcous changed the title Use Setuptools conventions in API instllation (v3) Use Setuptools conventions in API installation Oct 6, 2017
@mcous mcous added this to the v3 milestone Oct 6, 2017
@mcous mcous added api Affects the `api` project chore labels Oct 6, 2017
@astaff astaff mentioned this issue Nov 13, 2017
6 tasks
@mcous
Copy link
Contributor

mcous commented Dec 20, 2017

I would like to float pipenv as a better dependency management solution. @btmorr has been playing around with it, and it looks like there's some Windows issues. It's use would probably be dependent on continued Windows build environment simplification

@mcous mcous unassigned jarmg Dec 20, 2017
@astaff
Copy link
Contributor Author

astaff commented Dec 20, 2017

Our python package dependencies seems to be in the right place. Run dependencies are in setup.py, development/ci deps are in requirements.txt, compute's container uses setup.py. I haven't seen any windows issues with current setup. @btmorr let me know if there is anything we should improve.

@btmorr
Copy link
Contributor

btmorr commented Dec 20, 2017

I think this is resolved per the scope of the ticket. I've started exploring pipenv, and like the look of it, but not ready to actually switch it over yet. When we get to that point, I think we can open a separate ticket with the specifics request and rationale.

@btmorr btmorr closed this as completed Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project chore
Projects
None yet
Development

No branches or pull requests

4 participants