You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let's use pip install . that uses setup.py to install the package and it's dependencies required to run the API and keep build/ci dependencies in requrements.txt. Refer to #347 for further discussion
Chore
API, Docker, Makefiles
Version 3.x
steps to reproduce problem
This results in duplicating run dependencies in setup.py and requirements.txt to make non-compliant installation calls work.
The text was updated successfully, but these errors were encountered:
I would like to float pipenv as a better dependency management solution. @btmorr has been playing around with it, and it looks like there's some Windows issues. It's use would probably be dependent on continued Windows build environment simplification
Our python package dependencies seems to be in the right place. Run dependencies are in setup.py, development/ci deps are in requirements.txt, compute's container uses setup.py. I haven't seen any windows issues with current setup. @btmorr let me know if there is anything we should improve.
I think this is resolved per the scope of the ticket. I've started exploring pipenv, and like the look of it, but not ready to actually switch it over yet. When we get to that point, I think we can open a separate ticket with the specifics request and rationale.
overview
Let's use
pip install .
that usessetup.py
to install the package and it's dependencies required to run the API and keep build/ci dependencies inrequrements.txt
. Refer to #347 for further discussionsteps to reproduce problem
This results in duplicating run dependencies in
setup.py
andrequirements.txt
to make non-compliant installation calls work.The text was updated successfully, but these errors were encountered: