Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare well order modal for batch edit form #7228

Closed
IanLondon opened this issue Jan 19, 2021 · 0 comments · Fixed by #7375
Closed

Prepare well order modal for batch edit form #7228

IanLondon opened this issue Jan 19, 2021 · 0 comments · Fixed by #7375
Assignees
Labels
protocol designer Affects the `protocol-designer` project

Comments

@IanLondon
Copy link
Contributor

IanLondon commented Jan 19, 2021

Overview

The existing Well Order field components need to be refactored so that it can be reused in the Batch Edit Transfer form, while continuing to be used in single-edit mode (in MixForm + SourceDestFields).

For the overall approach, see #7301, which we'll follow for all the modal fields.

Acceptance Criteria

When you open Well Order, it should start with the defaults (Order: Top to Bottom then Left to Right). It should not indicate mixed state, just use defaults for both fields if either of the 2 well order fields are in an indeterminate state.

Once the modal is open, it therefore won't indicate indeterminate or not, and will preserve the validation it does now (= no validation needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
2 participants