Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Playwright #1722

Open
kylemh opened this issue Sep 10, 2023 · 6 comments
Open

Integrate Playwright #1722

kylemh opened this issue Sep 10, 2023 · 6 comments
Assignees
Labels
dependencies Pull requests that update a dependency file Type: Developer Experience / Refactoring

Comments

@kylemh
Copy link
Member

kylemh commented Sep 10, 2023

I want to use Playwright for Automated Visual Testing with Chromatic and eventually ditch snapshot tests + ditch Cypress.

Helpful: https://dev.to/szmydlo/comprehensive-coverage-jestplaywright-in-nextjs-ts-1df2

@kylemh kylemh added Type: Developer Experience / Refactoring dependencies Pull requests that update a dependency file labels Sep 10, 2023
@kylemh kylemh self-assigned this Sep 10, 2023
@michaelDragomir
Copy link
Contributor

@kylemh still want to do this?

@michaelDragomir
Copy link
Contributor

michaelDragomir commented Jun 7, 2024

@kylemh I made a PR for this integration. Should be done with it soon..currently testing it out...hopefully I didn't miss anything. but so far working smoothly..

@kylemh
Copy link
Member Author

kylemh commented Jun 8, 2024

Yes, I want to do this. I also want to try and use https://github.com/kwonoj/swc-plugin-coverage-instrument so that we can finally use SWC (and ditch Istanbul + Babel). This would allow our builds to be nearly twice as fast and our dev server would be MUCH faster.

@michaelDragomir
Copy link
Contributor

@kylemh i'll spend some time on this...and review that repo.

@kylemh
Copy link
Member Author

kylemh commented Jun 24, 2024

Im willing to ditch coverage too. So focus on Playwright replacing Cypress first. Coverage can come in a later PR. I'm updating some code in the other open PR too. Trying to get us to Next 14 asap

@michaelDragomir
Copy link
Contributor

alrighty...i'll open up a new PR and work on replacing Cypress with Playwright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Type: Developer Experience / Refactoring
Projects
None yet
Development

No branches or pull requests

2 participants