Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleAdsError and GoogleAdsFailure disappear on v7 #272

Closed
Zikoel opened this issue May 18, 2021 · 5 comments
Closed

GoogleAdsError and GoogleAdsFailure disappear on v7 #272

Zikoel opened this issue May 18, 2021 · 5 comments
Labels
dependencies 🔺 Pull requests that update a dependency file discussion 🗣️ Something needs discussion

Comments

@Zikoel
Copy link

Zikoel commented May 18, 2021

This is currently blocked as we're waiting on a reply from Google regarding the removal of the GoogleAdsError and GoogleAdsFailure objects, which we make use of for error handling internally in the library. We'll keep this PR updated when we hear back.

Originally posted by @kritzware in #271 (comment)

Just to understand whats happening (I will try but is very difficult to help you with lib internals especially with grpc autogenerated code), I see that this resources are on v7 protos as usual but not on the google-ads-node output so, the problem is on the generation step ?

@Zikoel Zikoel changed the title GoogleAdsErro and GoogleAdsFailure disappear on v7 GoogleAdsError and GoogleAdsFailure disappear on v7 May 18, 2021
@Zikoel
Copy link
Author

Zikoel commented May 20, 2021

After some digging I found this related issue maybe can help. The issue reporter say that the error was introduced on the version > 1.3.0 maybe (temporarily) is possible to regenerate the protos code with a previous version of the generator ?

@kritzware
Copy link
Contributor

Thanks for looking into this yourself @Zikoel.

A few days ago we discovered it was probably due to a bug in gapic-generator-typescript and we sent a message over to our Google contacts, after which they confirmed the issue. The issue you linked is the correct one to follow, so we're just waiting on that to be resolved before finishing off the V7 upgrade PR.

@kritzware kritzware added the discussion 🗣️ Something needs discussion label May 20, 2021
@kritzware kritzware added the dependencies 🔺 Pull requests that update a dependency file label May 20, 2021
@summer-ji-eng
Copy link

Thanks for the patient. This problem should be fix in googleapis/gapic-generator-typescript#878

@summer-ji-eng
Copy link

summer-ji-eng commented May 25, 2021

Shipped fixed PR in version 1.4.0. Thanks for the patience.

@kritzware
Copy link
Contributor

Going to close this now the issue has been resolved and as we prepare the V7 release! Thanks again @summer-ji-eng 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 🔺 Pull requests that update a dependency file discussion 🗣️ Something needs discussion
Projects
None yet
Development

No branches or pull requests

3 participants