-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GoogleAdsError and GoogleAdsFailure disappear on v7 #272
Comments
After some digging I found this related issue maybe can help. The issue reporter say that the error was introduced on the version |
Thanks for looking into this yourself @Zikoel. A few days ago we discovered it was probably due to a bug in gapic-generator-typescript and we sent a message over to our Google contacts, after which they confirmed the issue. The issue you linked is the correct one to follow, so we're just waiting on that to be resolved before finishing off the V7 upgrade PR. |
Thanks for the patient. This problem should be fix in googleapis/gapic-generator-typescript#878 |
Shipped fixed PR in version 1.4.0. Thanks for the patience. |
Going to close this now the issue has been resolved and as we prepare the V7 release! Thanks again @summer-ji-eng 👍 |
This is currently blocked as we're waiting on a reply from Google regarding the removal of the
GoogleAdsError
andGoogleAdsFailure
objects, which we make use of for error handling internally in the library. We'll keep this PR updated when we hear back.Originally posted by @kritzware in #271 (comment)
Just to understand whats happening (I will try but is very difficult to help you with lib internals especially with grpc autogenerated code), I see that this resources are on v7 protos as usual but not on the google-ads-node output so, the problem is on the generation step ?
The text was updated successfully, but these errors were encountered: