Brave Wallet Connection

[micahalcorn]

In #634, I mentioned that the built-in Brave wallet works out of the box with our injected connector (same for MetaMask and Coinbase Wallet) but I didn't know if there was a way to distinguish the built-in wallet from a MetaMask extension installed in the Brave Browser.

Similarly, @calvintoes mentioned in #838 that the built-in Brave wallet works via Wallet Link as well. I'm not sure if they distinguish Brave's wallet from MetaMask's either.

Here's some guidance from the Brave team if we decide to roll our own:

We’re not a MetaMask fork anymore but we do return true for ethereum.isMetaMask because we aim to be fully compatible with MetaMask.

It’s better to feature test for things rather than to rely on a flag like isMetaMask but if you just want to give an indication that it is Brave that’s connected then you can use web3_clientVersion brave/brave-browser#19278

Please note that the value for Brave will be changing once that issue is implemented ,but at least you can check that it doesn’t give the same value as MetaMask for now to tell the difference between MetaMask and Brave Wallet. So you can check the value of web3_clientVersion and also isMetaMask == true to tell if it’s really MetaMask and not Brave Wallet.

[calvintoes]

Slight misunderstanding. I tried Brave wallet out of the box (and connected using MM) because I thought it was just another MM wallet. Did not know it was a separate thing.

I did not try it with WalletLink. I only tried it with the injected connector.