Item reward abusable by leaving space in inventory

[P0nk]

Silwhoon:

In ItemRewardHandler.java, players can exploit usable items by filling their inventories and only leaving space for the item they want. As it only checks if the player has space for the selected random reward, rather than checking if the player has space for any potential reward

Ponk:

I don't really see it being the way you explain. It is abusable, but only for the 1st potential reward in the list.
Another issue I spotted is that there's a chance that no item is rewarded since a new random int is generated for each potential reward instead of once at the beginning.

Relevant lines: https://github.com/P0nk/Cosmic/blob/master/src/main/java/net/server/channel/handlers/ItemRewardHandler.java#L57-L82

[P0nk]

Solution: check for an empty space in all inventory tabs that are possible among all the item rewards.