Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict requirement on protobuf/toml versions? #17

Closed
matthiasdiener opened this issue Jul 31, 2023 · 1 comment
Closed

Strict requirement on protobuf/toml versions? #17

matthiasdiener opened this issue Jul 31, 2023 · 1 comment

Comments

@matthiasdiener
Copy link

Description

This came up in conda-forge/austin-python-feedstock#13 . Currently, austin-python has quite strict requirements on the versions of the protobuf and toml packages (from pyproject.toml):

  "protobuf~=3.12.2",
  [...]
  "toml~=0.10.2",

Are these versions required, or can we use newer versions of protobuf and toml?

Steps to Reproduce

n/a

Expected behavior: [What you expect to happen]

Actual behavior: [What actually happens]

Reproduces how often: [What percentage of the time does it reproduce?]

Versions

1.5.0

Additional Information

n/a

@P403n1x87
Copy link
Owner

P403n1x87 commented Jul 31, 2023

Thanks for reporting this @matthiasdiener . This is an interesting question. For toml I believe we can relax the pin, to the point where we can remove it entirely starting with 3.11. The protobuf dependency is only really needed for the tool that comes with the library, so that could be pushed into extras perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants