Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cron.matchDate always returning true for day of month, when either weekday or day of month is unrestricted #271

Merged
merged 3 commits into from Apr 27, 2022
Merged

fix: cron.matchDate always returning true for day of month, when either weekday or day of month is unrestricted #271

merged 3 commits into from Apr 27, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2022

No description provided.

@P4sca1
Copy link
Owner

P4sca1 commented Apr 27, 2022 •
edited
Loading

@renzo-s Thank you for the pull request! Could you please target your PR against the dev branch? Every commit to master automatically drafts a new release and I would like to release your bug fix together with other changes.
I already added tests to the dev branch for the issue that you reported, which currently fail. Hopefully these turn green when your PR arrives.

Edit: Nevermind, I found a way to do this without the need to rebase.

@P4sca1 P4sca1 linked an issue Apr 27, 2022 that may be closed by this pull request
Cron.matchDate returns always true when using weekdays and days of month #270
Closed
@P4sca1 P4sca1 changed the title resolves #270 fix: cron.matchDate always returning true for day of month, when either weekday or day of month is unrestricted. Apr 27, 2022
@P4sca1 P4sca1 changed the title fix: cron.matchDate always returning true for day of month, when either weekday or day of month is unrestricted. fix: cron.matchDate always returning true for day of month, when either weekday or day of month is unrestricted Apr 27, 2022
@P4sca1 P4sca1 merged commit 8ebd6a6 into P4sca1:master Apr 27, 2022
P4sca1 pushed a commit that referenced this pull request Apr 27, 2022
@semantic-release-bot
chore(release): 3.0.6 [skip ci]
0bff686 
## [3.0.6](v3.0.5...v3.0.6) (2022-04-27)

### Bug Fixes

* cron.matchDate always returning true for day of month, when either weekday or day of month is unrestricted ([#271](#271)) ([8ebd6a6](8ebd6a6)), closes [#270](#270) [#270](#270)
@P4sca1
Copy link
Owner

P4sca1 commented Apr 27, 2022

🎉 This PR is included in version 3.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost
Copy link
Author

ghost commented Apr 28, 2022 •
edited by ghost
Loading

🎉 Thanks for integrating so quickly! Sorry wasn't aware of your CI-pipeline. Rebasing is something I also try and avoid if possible. Possibly because I don't understand it fully ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cron.matchDate returns always true when using weekdays and days of month
2 participants
@P4sca1 @renzos42