Two or more singleton dimensions (bs550aer)

[kjoti]

Hi, i am koji.

The problem occurs in the following cases:

1. The variable has two or more singleton dimensions
2. Users omit the 'axes_ids' of these singleton dimensions when invoking cmor_variable()

CMOR automatically adds the singleton dimensions if needed,
so omitting them is allowed and very common.

It's easy to fix this problem. Apply the following patch:

diff --git a/Src/cmor_variables.c b/Src/cmor_variables.c
index 24ca3ff..dc67faa 100644
--- a/Src/cmor_variables.c
+++ b/Src/cmor_variables.c
@@ -1533,7 +1533,7 @@ int cmor_variable(int *var_id, char *name, char *units, int ndims,
                                   1, &pAxis->value, 'd', NULL, 0, "");
                     }
 
-                    laxes_ids[olndims] = k;
+                    laxes_ids[olndims + lndims] = k;
                     lndims += 1;
                 }

'olndims' does not change while looping and 'lndims' is incremented
(starting with zero). So in the case of only one singleton dimension,
the previous code is ok.
But generally the index of 'laxes_ids' should be 'olndims + lndims'.

[mauzey1]

@kjoti
Hi Koji. Thank you for helping solve this problem.

Could you submit these changes as a pull request to our repo's master branch? You can do this by making a fork of this repo, making changes in your fork, and submitting a pull request to merge your fork's branch into ours. This makes it easier to track changes provided by contributors to this project.

Thank you,

Chris

[kjoti]

@mauzey1
Please check #468