Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Control Vocabulary" should be named "Controlled Vocabulary" #55

Closed
jypeter opened this issue Jul 3, 2018 · 2 comments · Fixed by #78
Closed

"Control Vocabulary" should be named "Controlled Vocabulary" #55

jypeter opened this issue Jul 3, 2018 · 2 comments · Fixed by #78
Assignees

Comments

@jypeter
Copy link

jypeter commented Jul 3, 2018

@dnadeau4 I think you should replace control with controlled in several places of https://cmor.llnl.gov/mydoc_cmor3_CV/ and possibly other pages, in order to be consistent with the way @durack1 is using it on https://github.com/WCRP-CMIP/CMIP6_CVs

@mauzey1
Copy link
Collaborator

mauzey1 commented May 13, 2019

@doutriaux1 @durack1 There are several places that use the term "controlled vocabulary" but the parameter in the user input of CMOR is named "_control_vocabulary_file"

https://github.com/PCMDI/cmor/blob/e066e2b02bccde1104de3c18ad06c75f4cd70c0a/include/cmor.h#L191

https://github.com/PCMDI/cmor/blob/e066e2b02bccde1104de3c18ad06c75f4cd70c0a/Test/CMOR_input_example.json#L60

Should we change that parameter's name to match the documentation?

@durack1
Copy link
Contributor

durack1 commented May 13, 2019

@mauzey1 sure, for consistency this sounds like a nice tweak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants