Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: Final Fantasy X Optimal FPU config #11958

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

vcx33
Copy link
Contributor

@vcx33 vcx33 commented Oct 28, 2024

Description of Changes

Changed EE rounding mode from negative to positive for Final Fantasy X and the International version, as well as removing obsolete VU0 clamping lines and adding missing HW hacks for the international version of the game.

Rationale behind Changes

Fixes the vast majority of FFX's FPU glitches as well as fixing a major cutscene bug without breaking anything more than what the current config already breaks.

EE clamping fixes reverse controls and characters and enemies facing the wrong way during battles, everything else is affected by EE rounding and EE division rounding.

VU0 clamping affects nothing.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@@ -70232,4 +70232,4 @@ TLES-82043:
autoFlush: 2 # Fixes lens flare.
halfPixelOffset: 4 # Aligns depth of field effect.
nativeScaling: 2 # Fixes post lighting.
getSkipCount: "GSC_MetalGearSolid3" # Fixes depth of field blur.
getSkipCount: "GSC_MetalGearSolid3" # Fixes depth of field blur.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got an issue here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the issue exactly?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the issue exactly?

image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nvm, I think this is because it's the end of the file. My bad

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing a newline at the end of the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do i have to create a new empty line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Felipefpl
Copy link

Description of Changes

Changed EE rounding mode from negative to positive for Final Fantasy X and the International version, as well as removing obsolete VU0 clamping lines and adding missing HW hacks for the international version of the game.

Rationale behind Changes

Fixes the vast majority of FFX's FPU glitches as well as fixing a major cutscene bug without breaking anything more than what the current config already breaks.

EE clamping fixes reverse controls and characters and enemies facing the wrong way during battles, everything else is affected by EE rounding and EE division rounding.

VU0 clamping affects nothing.

Hi, will this fix any of the issues reported here?

https://github.com/PCSX2/pcsx2/issues?q=is%3Aissue%20state%3Aopen%20fantasy%20x

@vcx33
Copy link
Contributor Author

vcx33 commented Oct 29, 2024

Description of Changes

Changed EE rounding mode from negative to positive for Final Fantasy X and the International version, as well as removing obsolete VU0 clamping lines and adding missing HW hacks for the international version of the game.

Rationale behind Changes

Fixes the vast majority of FFX's FPU glitches as well as fixing a major cutscene bug without breaking anything more than what the current config already breaks.
EE clamping fixes reverse controls and characters and enemies facing the wrong way during battles, everything else is affected by EE rounding and EE division rounding.
VU0 clamping affects nothing.

Hi, will this fix any of the issues reported here?

https://github.com/PCSX2/pcsx2/issues?q=is%3Aissue%20state%3Aopen%20fantasy%20x

It will fix an issue where a character walks in place during a cutscene. As mentioned here: #10885

@lightningterror lightningterror added this to the Release 2.4 milestone Oct 30, 2024
@lightningterror lightningterror merged commit b95eb5c into PCSX2:master Nov 4, 2024
13 checks passed
SternXD pushed a commit to EmulationCollective/XBSX2 that referenced this pull request Dec 7, 2024
Fixes the vast majority of FFX's FPU glitches as well as fixing a major cutscene bug without breaking anything more than what the current config already breaks.

EE clamping fixes reverse controls and characters and enemies facing the wrong way during battles, everything else is affected by EE rounding and EE division rounding.

VU0 clamping affects nothing.
RedPanda4552 pushed a commit to RedPanda4552/pcsx2 that referenced this pull request Dec 20, 2024
Fixes the vast majority of FFX's FPU glitches as well as fixing a major cutscene bug without breaking anything more than what the current config already breaks.

EE clamping fixes reverse controls and characters and enemies facing the wrong way during battles, everything else is affected by EE rounding and EE division rounding.

VU0 clamping affects nothing.
SternXD pushed a commit to EmulationCollective/XBSX2 that referenced this pull request Dec 22, 2024
Fixes the vast majority of FFX's FPU glitches as well as fixing a major cutscene bug without breaking anything more than what the current config already breaks.

EE clamping fixes reverse controls and characters and enemies facing the wrong way during battles, everything else is affected by EE rounding and EE division rounding.

VU0 clamping affects nothing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants