PINE: Fix stack buffer overflow for long XDG_RUNTIME_DIR paths #12026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoticgd
force-pushed
the
pine_buffer_overflow
branch
from
2b3c4ae to
3f86f53
Compare
F0bes
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
A
strcpycall has been swapped out with astrncpyStringUtil::Strlcpycall inPINEServer::Initialize.Rationale behind Changes
For example, on Linux you could previously make it crash with the following command if PINE was enabled:
Suggested Testing Steps
Try the command above, make sure it doesn't crash.