Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alfven test noise #712

Open
nicolasaunai opened this issue Jan 4, 2023 · 5 comments
Open

alfven test noise #712

nicolasaunai opened this issue Jan 4, 2023 · 5 comments
Assignees
Labels
bug 🔥 Something isn't working
Milestone

Comments

@nicolasaunai
Copy link
Member

nightly build test "alfven wave" shows a very large and unusual noise in build of the branch syncmoments of PR #697 .
Other tests do not show issues. The alfven wave seems to still propagate OK since the wave speed is correct, but a large noise arises on the refined level.

image

A priori this seems to be the "typical" issue of the Niquyst mode piling up onto the fine level that is usually fixed with hyperresistive dissipation. What's weird is that for this test the hyperresistivity is 1e-3, which is very weak for dx=1 (L0) and dx=0.5 (L1) and so we should have seen this issue already before.

@nicolasaunai nicolasaunai added the bug 🔥 Something isn't working label Jan 4, 2023
@nicolasaunai nicolasaunai self-assigned this Jan 4, 2023
@nicolasaunai
Copy link
Member Author

Here is what I get for master (3947023) :

alfven_wave

and for the branch levelghostinterp (7db2c9d) :

alfven_wave

It looks like on levelghostinterp there is more noise than on master on the refined level. To what extent this is just a random deviation that could also happen on master or related to the diff introduced (fixing time interpolation of level ghost particles) is unclear.

@nicolasaunai
Copy link
Member Author

on branch syncmoments: Increasing hyper-resistvity from 0.001 to 0.01 surprisingly does not help

alfven_wave

@nicolasaunai
Copy link
Member Author

Increasing hyper-resistivity to 0.02 or 0.05 does not help. Probably need to smooth and revive #511. Testing harris with dynamic refinement now. Given that tdtagged1d works ok, it is possible that the fixed refinement boundaries here do not help and moving boundaries prevent pile up of grid scale fluctuations.

@nicolasaunai
Copy link
Member Author

Tested Harris with dynamic refinement (from the Paper's test case) and it seems OK:
image

What probably happens in the case of the Aflven test, is that the fixed refinement area leaves time for the high freq. noise to pile up and grow. With dynamic refinement, the motion and removal of refined patches also removes high freq. modes and effectively acts as a dynamical filter.

I let this issue open until smoothing is implemented #511 to see if that helps. Considering fixed refinement for a million time step is not the main use case and Harris still works, this issue is probably not so major.

@nicolasaunai nicolasaunai added this to the PHARE 1.0 milestone Oct 13, 2023
@nicolasaunai nicolasaunai modified the milestones: 1.1, 1.2 Dec 14, 2023
@nicolasaunai nicolasaunai modified the milestones: 1.1, 1.0.1 Jul 23, 2024
@nicolasaunai
Copy link
Member Author

PR #867 fixed the straight lines by changing the way 1D plots are made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🔥 Something isn't working
Projects
Status: Fix me 🔥
Development

No branches or pull requests

1 participant