From 54e664c4fda401010976cbfa757382fc3103dba3 Mon Sep 17 00:00:00 2001
From: Eli <88557639+lishaduck@users.noreply.github.com>
Date: Tue, 19 Dec 2023 17:13:30 -0600
Subject: [PATCH] chore: update gha and vs code configs

---
 .github/workflows/deno.yaml |  5 ++++-
 .vscode/extensions.json     |  3 ++-
 .vscode/settings.json       | 13 ++++++++-----
 biome.json                  |  2 +-
 deno.json                   | 35 ++---------------------------------
 5 files changed, 17 insertions(+), 41 deletions(-)

diff --git a/.github/workflows/deno.yaml b/.github/workflows/deno.yaml
index fad0b03e..a3df6a52 100644
--- a/.github/workflows/deno.yaml
+++ b/.github/workflows/deno.yaml
@@ -59,7 +59,10 @@ jobs:
         run: deno cache src/main.ts
 
       - name: 🕵️ Run linter, Verify formatting
-        run: deno task check
+        run: deno task ci
+
+      - name: 🕵️ Typecheck
+        run: deno task typecheck
 
       - name: 🧪 Run tests
         run: deno task test
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
index 455f9fcd..09dba4d6 100644
--- a/.vscode/extensions.json
+++ b/.vscode/extensions.json
@@ -1,6 +1,7 @@
 {
   "recommendations": [
     "denoland.vscode-deno",
-    "bradlc.vscode-tailwindcss"
+    "bradlc.vscode-tailwindcss",
+    "biomejs.biome"
   ]
 }
diff --git a/.vscode/settings.json b/.vscode/settings.json
index 99dcbfda..db9437cd 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -1,17 +1,20 @@
 {
   "deno.enable": true,
-  "deno.lint": true,
   "[typescriptreact][typescript]": {
-    "editor.defaultFormatter": "denoland.vscode-deno"
+    "editor.defaultFormatter": "biomejs.biome"
   },
   "[javascriptreact][javascript]": {
-    "editor.defaultFormatter": "denoland.vscode-deno"
+    "editor.defaultFormatter": "biomejs.biome"
   },
   "[markdown]": {
-    "editor.defaultFormatter": "denoland.vscode-deno"
+    "editor.defaultFormatter": "biomejs.biome"
   },
   "[json]": {
-    "editor.defaultFormatter": "denoland.vscode-deno"
+    "editor.defaultFormatter": "biomejs.biome"
+  },
+  "editor.codeActionsOnSave": {
+    "quickfix.biome": true,
+    "source.organizeImports.biome": "always"
   },
   "css.customData": [
     ".vscode/tailwind.json"
diff --git a/biome.json b/biome.json
index 422461fa..0500ee59 100644
--- a/biome.json
+++ b/biome.json
@@ -27,7 +27,7 @@
     "clientKind": "git"
   },
   "files": {
-    "ignore": [".vscode", "*.gen.ts"]
+    "ignore": [".vscode/", "*.gen.ts"]
   },
   "javascript": {
     "globals": ["Deno"]
diff --git a/deno.json b/deno.json
index f52c5250..0d5e6977 100644
--- a/deno.json
+++ b/deno.json
@@ -2,6 +2,7 @@
   "lock": false,
   "tasks": {
     "check": "deno task lint && deno task typecheck",
+    "ci": "deno task biome ci .",
     "typecheck": "deno check **/*.ts **/*.tsx",
     "lint": "deno task biome check .",
     "test": "deno test --allow-env --allow-read --coverage=cov/",
@@ -17,39 +18,7 @@
     "esm:remove": "deno run -A https://esm.sh/v135 remove",
     "biome": "deno run -A npm:@biomejs/biome"
   },
-  "lint": {
-    "rules": {
-      "tags": [
-        "fresh",
-        "recommended"
-      ],
-      "include": [
-        "ban-untagged-todo",
-        "camelcase",
-        "default-param-last",
-        "eqeqeq",
-        "explicit-function-return-type",
-        "explicit-module-boundary-types",
-        "guard-for-in",
-        "no-await-in-loop",
-        "no-console",
-        "no-const-assign",
-        "no-eval",
-        "no-external-import",
-        "no-implicit-declare-namespace-export",
-        "no-non-null-asserted-optional-chain",
-        "no-sparse-arrays",
-        "no-sync-fn-in-async-fn",
-        "no-throw-literal",
-        "no-undef",
-        "single-var-declarator"
-      ]
-    }
-  },
-  "exclude": [
-    "**/_fresh/*",
-    "src/fresh.gen.ts"
-  ],
+  "exclude": ["**/_fresh/*", "src/fresh.gen.ts"],
   "imports": {
     "$std/": "https://deno.land/std@0.209.0/",
     "$fresh/": "https://deno.land/x/fresh@1.6.1/",