Add Language Mode "javascriptreact" #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"javascriptreact" is a language mode that replace the default "javascript" mode when a .js is opened in vscode. This can be done via the settings:
````json
{
"files.associations": {
"*.js": "javascriptreact"
}
}
````
So I choose the already present "react.svg" file inside the icons folder to do the maching.
wopian
reviewed
Oct 20, 2017
src/material-icons.json
Outdated
| @@ -33,6 +33,9 @@ | |||
| "_file_js": { | |||
| "iconPath": "./../../icons/javascript.svg" | |||
| }, | |||
| "_file_jsreact": { | |||
There was a problem hiding this comment.
_file_react already exists with this icon
There was a problem hiding this comment.
So I can map _file_react with javascriptreact "languageIds" field and remove _file_jsreact
madiodio
commented
Oct 20, 2017
src/material-icons.json
Outdated
| @@ -33,6 +33,9 @@ | |||
| "_file_js": { | |||
| "iconPath": "./../../icons/javascript.svg" | |||
| }, | |||
| "_file_jsreact": { | |||
There was a problem hiding this comment.
So I can map _file_react with javascriptreact "languageIds" field and remove _file_jsreact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"javascriptreact" is a language mode that replace the default "javascript" mode when a .js is opened in vscode. This can be done via the settings:
{ "files.associations": { "*.js": "javascriptreact" } }So I choose the already present "react.svg" file inside the icons folder to do the maching.