Adding new folder icons bis

[AdrieanKhisbe]

Follow up of #339, A new serie of icons. 🎨

• Add two new folder icon e2e for end to end test and custom 95e6f7e
• Singularize screenshot and icon folder icons from images 92954c6
• Add icon for grunt folder cdde91d
• Add the forgotten docker-compose.test.yml to the dockers file e1de3ba

I've some other icons in the go, there are still are research stage

[AdrieanKhisbe]

Here are the other icons I have in mind:
Feedback are more than welcome!! :)

• scenario: https://material.io/tools/icons/?icon=video_call&style=baseline
• mock/fixtures: https://material.io/tools/icons/?icon=compare&style=baseline
• vm: https://material.io/tools/icons/?icon=laptop_chromebook&style=baseline
• styleguide: https://material.io/tools/icons/?icon=photo_album&style=baseline
• stylus: stylus dedicated icon
• flow: dedicated icon
• (.)storybook: decicated icon
• syntaxes: https://material.io/tools/icons/?icon=local_library&style=baseline

[AdrieanKhisbe]

Also Pimped up NodeJs icon to please a collegue

[PKief]

Wow, very cool! I very appreciate your work! At a first glance the icons look very good, but I still have to review them in more detail 👍

---

I'd like to give you another tip to make the folder icons even better. Usually I make the smaller front icon overlap slightly over the right and bottom edges of the folder icon:

Yours	Improved

I tried to make this for each folder icon in the theme as far as possible to get a consistent look.

It'd be great if you could improve that a little bit for your icons.

But thank you very much, you did a great job (again) 😄

[AdrieanKhisbe]

Cool!
About icon overlapping, you're right, I really have overlook it for this one. And maybe some.
I'll ping you when I'll have them fix, and the other ones mentioned added.

😃

[AdrieanKhisbe]

Et voilà. I complete the folder icons, and tweaked the one that need to be done.
Here is a preview:

[PKief]

@AdrieanKhisbe Looks great 😃. I'll review it soon.

[AdrieanKhisbe]

👌 =)

[PKief]

node !== npm

I think the node folder icon does not fit very good to the npm folder. And I haven't seen so many npm folders before, not sure if we need an icon for that folder at all.

[AdrieanKhisbe]

you're right

[PKief]

These two folder names are very specific, not sure if I'll add them to the theme. If people want these icons they can assign them manually in the user settings.

[AdrieanKhisbe]

I see your point, I forgot this was possible. =)
(just found it in the readme: https://github.com/PKief/vscode-material-icon-theme#folder-associations)

[AdrieanKhisbe]

@PKief I just applied your recommendations =)

[PKief]

Alright, I spend some time to review the icons and also to create some new icons. Finally these icons will be added to the theme:

Added folder icons:
- animation
- review
- rules
- syntax

Updated folder icons:
- coverage (updated color)
- custom (pencil is more intuitive)
- flow (updated color)
- mock (pencil is more intuitive)
- stylus (updated color)
- vm (updated color)

Rejected folder icons:
- e2e (uses coverage icon now)
- grunt (not suitable)
- icon (uses the images icon, does not need another icon)
- node (current icon is nice)
- scenario (not common and not so suitable)
- screenshot (images folder is enough for that, a screenshot folder still contains images)
- storybook (not suitable -> see #235 (comment))
- styleguide (not common and not so suitable)
- idea (not suitable)

Updated file icons:
- virtual (another icon)
- stylus (small improvement)

---

Further explanations:
"not suitable" means that it does not really fit to the other icons in the theme. It has nothing to do with your work, I couldn't do any better (I even tried to work on each of them). But it is better to omit some icons than that the quality of the theme suffers from it.

In my opinion, the folder icons "Screenshot" and "Icons" can definitely be replaced by the default image folder icon, I don't see any real enrichment here.

I made the "vm" folder icon blue because of the existing file icon for virtual box files (*.vbox):

"e2e" and the existing "coverage" icon looked very similar, which is why I use the already existing coverage icon and adjusted the color a little bit.

For the "mock" and "custom" folder icons I decided to use a pencil as the motive and another color for "mock" because I think this is more intuitive:

Yours	New version

To note this again, I really appreciate your work and the icons are great and you've great ideas. If I decide not to use an icon, it doesn't mean that you did a bad job, but that the icon doesn't fit properly. I hope that you understand my decisions 😅

Ok so far so good 👍
Thank you very much!

[PKief]

Merged with this commit cfec8f1.

[AdrieanKhisbe]

Hey @PKief,
Just seeing now your message.
No problem with some icons being not take, I do understand your position and agree some were not "suitable", and though to me screenshot&icons looked nice, we can do for sure with just the pictures.
Your additions are great, and the mock+custom are way better than my original design.

---

I'm almost settle with the folders icons, just remain a last icon to crack, the .idea folder which can be very common.
Have you some ideas?

I was thinking either just keeping a bordered squared with ID.
Or doing a more generic editor icon that we could use for other editors folder like atom.
With an icon like: https://material.io/tools/icons/?icon=format_size&style=baseline

[PKief]

Yes, the .idea folder is very common. Maybe something like this could be possible:

But I'm still not very sure, I've to think about it. Let's see.

I'm against a generic folder icon for such folders, then I'd rather have none ;)

[AdrieanKhisbe]

That icon folder looks very nice!