Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prisma Folder Icons #383

Closed
wants to merge 1 commit into from
Closed

Add Prisma Folder Icons #383

wants to merge 1 commit into from

Conversation

epitaphmike
Copy link
Contributor

Added prisma folder icons.

screen shot 2019-01-27 at 10 06 14 pm

screen shot 2019-01-27 at 10 05 57 pm

@PKief
Copy link
Member

PKief commented Feb 3, 2019

Thank you, the icon looks pretty good! I did some very small improvements and merged your pull request with 4d0fbcb.

@PKief PKief closed this Feb 3, 2019
@epitaphmike
Copy link
Contributor Author

epitaphmike commented Feb 11, 2019 •
edited
Loading

Awesome! Looks good.
What did you change?

@PKief
Copy link
Member

PKief commented Feb 11, 2019

I slightly moved the prisma logo to the left to have a smaller gap on the right side:

Yours Updated
prisma folder icon updated prisma folder icon

I think it looks slightly better in the explorer:

Yours Updated
prisma folder icon in explorer updated prisma folder icon in explorer

@epitaphmike
Copy link
Contributor Author

Much better. Could probably even afford to be bumped up a little too. Either way, an improvement!

@PKief
Copy link
Member

PKief commented Feb 11, 2019

Thank you! I think it's very good now, I can live with it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epitaphmike @PKief