Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestJS Icons - add main Filetypes to NestJS #501

Merged
merged 1 commit into from
Aug 25, 2019
Merged

NestJS Icons - add main Filetypes to NestJS #501

merged 1 commit into from
Aug 25, 2019

Conversation

jerriclynsjohn
Copy link
Contributor

Made essential changes to accommodate NestJS as right now icons of angular type are shown as default as both use same file naming convention, so it was essential to create a new IconType.

Main Changes made:

  1. Updates the main NestJS logo color for main files (nest-cli.json, nestconfig.json ...)
  2. Persistence Layer file types - blue color (dto, interfaces, entity, model, enum and repository)
  3. Module file type - red color
  4. Controller file type - green color
  5. Service file type - yellow color
  6. Decorator file type - purple color
  7. Pipe file type - dark green color
  8. IconType of Nest
  9. Enumeration in package.json
  10. Translation in all languages for NestJS entry

@PKief PKief mentioned this pull request Jul 28, 2019
@jerriclynsjohn
Copy link
Contributor Author

Do let me know if i should add more icons for nestjs framework, I'm using a customized version of this plugin. I could create another PR which has more icons.

@PKief
Copy link
Member

PKief commented Aug 6, 2019

@jerriclynsjohn Thank you very much, I'll take a look into your pull request, soon.

@PKief PKief self-requested a review August 25, 2019 12:09
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerriclynsjohn I just reviewed the pull request and it looks great. But I decided to change some things:

  • renamed icon files with respect to their purpose (e.g. "nest-controller.svg")
  • made icons a little bit smaller
  • changed color of controller icon into "blue"
  • removed icon for "interface", "entity", etc. because it's not so NestJS specific, but more a standard TypeScript file
  • added more icons for "middleware", "guard", "filter" and "gateway"

The final result will look like this:

nest.js file icons

Again, thank you very much for this pull request. You did a very good job 👍

PKief added a commit that referenced this pull request Aug 25, 2019
PKief added a commit that referenced this pull request Aug 25, 2019
PKief added a commit that referenced this pull request Aug 25, 2019
@PKief PKief merged commit 102bbad into material-extensions:master Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants