Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codecov icon #537

Merged
merged 21 commits into from
Nov 3, 2019
Merged

add codecov icon #537

merged 21 commits into from
Nov 3, 2019

Conversation

yardenshoham
Copy link
Contributor

The icon will be used for .codecov.yml or codecov.yml, the configuration file for codecov.

Icon

ezgif-2-edaa841e0450

@PKief PKief self-requested a review November 1, 2019 12:40
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks good, will be merged soon 👍

@PKief PKief merged commit 57244be into material-extensions:master Nov 3, 2019
@yardenshoham
Copy link
Contributor Author

Merged! Great, could I be added to the contributors in README?

@PKief
Copy link
Member

PKief commented Nov 3, 2019

Sure, I usually update the README before each release and this also includes the contributors list 👍

@hootener
Copy link

hootener commented Dec 4, 2019

👋 Hi @PKief and @yardenshoham. Thanks for adding our branding to the excellent Material Icon Theme. I only noticed this because this is theme I use myself in VSCode. It was cool to see all my codecov.yml's sporting our pink umbrella!

@PKief
Copy link
Member

PKief commented Dec 4, 2019

@hootener I'm glad you like it 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants