Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Vitejs #948

Merged
merged 5 commits into from
Feb 21, 2021
Merged

Adding support for Vitejs #948

merged 5 commits into from
Feb 21, 2021

Conversation

yousefelgoharyx
Copy link
Contributor

Support for vitejs. Sorry if i shouldn't have pushed to master but this is my first contribution to any repo actually

@PKief PKief self-requested a review February 7, 2021 15:35
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Unfortunately, the proposed icon does not fit so good into this extension:

image

I think the icon would look much better as a file icon if we'd simply use a flash as the icon:

image

Would this be also fine for you?

@yousefelgoharyx
Copy link
Contributor Author

You know better what fits and what doesn't so yes I'm pretty fine
Also while looking at create-vite-app repo
I noticed that TS templates actually use vite.config.ts so do I make another pull request or simply an issue? since it's not really something
Just another element in an array

https://github.com/vitejs/create-vite-app/tree/master/template-react-ts
Thanks for your time.

@PKief
Copy link
Member

PKief commented Feb 21, 2021

Thanks for the feedback, I also added vite.config.ts to the array :)
The icon will be part of the upcoming update.

@PKief PKief merged commit 80de83c into material-extensions:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants