Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve response error message #304

Closed
martinolmos opened this issue Apr 30, 2019 · 3 comments
Closed

Improve response error message #304

martinolmos opened this issue Apr 30, 2019 · 3 comments

Comments

@martinolmos
Copy link

Hi,

Thanks por this package, it's been really helpfull.

I'm getting the Error in get_widget(comparison_item, category, gprop, hl, cookie_url, : widget$status_code == 200 is not TRUE. Pretty sure I'm being rate limited but maybe it would be a good idea to display the error status code?

@PMassicotte
Copy link
Owner

Can you make aPR?

@JBleher
Copy link
Contributor

JBleher commented May 2, 2019

Just a question: With which status does google reply if the rate limit is due? I think it is not possible to distinguish the rate limit from an error in the query? I think you will get a reponse in the 400s? But I might be wrong... eager to learn. So how would you go about it @martinolmos ?

@PMassicotte
Copy link
Owner

Good question @JBleher I still do not know, but I will change the error message so it is at least printed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants