Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level horizon calibration transients #11275

Closed
RomanBapst opened this issue Jan 22, 2019 · 6 comments
Closed

Level horizon calibration transients #11275

RomanBapst opened this issue Jan 22, 2019 · 6 comments

Comments

@RomanBapst
Copy link
Contributor

RomanBapst commented Jan 22, 2019

Describe the bug
It seems like the board rotation parameters are set to zero prior to performing the attitude calibration. In some cases this can cause attitude transients which impact the average measured attitude.

I'll follow up with a plot if not already with a fix.

@RomanBapst RomanBapst self-assigned this Jan 22, 2019
@RomanBapst RomanBapst added the bug label Jan 22, 2019
@RomanBapst
Copy link
Contributor Author

@sanderux FYI

@julianoes
Copy link
Contributor

@RomanBapst is this still an issue?

@PX4 PX4 deleted a comment from stale bot Jul 15, 2019
@PX4 PX4 deleted a comment from stale bot Jul 15, 2019
@stale
Copy link

stale bot commented Oct 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Oct 13, 2019
@julianoes
Copy link
Contributor

@RomanBapst it would be good if you can follow up on these things, thanks.

@stale stale bot removed the stale label Oct 14, 2019
@RomanBapst
Copy link
Contributor Author

@julianoes This problem was reported by @sanderux and I created this issue so that we don't forget about it. I have just tried to do a level calibration with a 30 degrees offset on both roll and pitch and the level horizon calibration worked just fine. The algorithm was waiting long enough for the transient of the attitude solution to decay.
Given that this is the only issue I've ever seen about this and I cannot reproduce the problem I'm going to close this.
@sanderux If you have a log of a failure case please share it here and we can have a look at it.

@RomanBapst
Copy link
Contributor Author

@julianoes @sanderux This should now be fixed for good since @bkueng did changes to the calibration routine such that the calibration is performed relative to the current board offset.
#13666 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants