Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPE Q Estimator external heading fusion not handling lack of external data #11433

Closed
ArkadiuszNiemiec opened this issue Feb 11, 2019 · 2 comments

Comments

@ArkadiuszNiemiec
Copy link
Contributor

ArkadiuszNiemiec commented Feb 11, 2019

I am using an LPE with an external vision system and yaw information fused in Q Estimator. It works pretty well even without a mag sensor (this currently does not work in EKF2). The problem is that my external estimator can have up to a few seconds pauses in which no new yaw data is published.
I have found out that if the last yaw position is e.g. x radian the Q Estimator is still converging to this number even if gyro has correctly reported 90-degree turn.

Steps to reproduce the behavior:

  1. PX4 with LPE estimator, external vision estimator and external vision yaw fused in Q Estimator.
  2. Turn off mag sensor.
  3. Let the ATTITUDE.yaw converge to VISION_POSITION_ESTIMATE.yaw.
  4. Turn off external vision system.
  5. Rotate the autopilot 90 degrees.
  6. Watch ATTITUDE.yaw converge back to the last data reported by the external vision system.

Expected behavior:
The Q estimator should turn off external vision data if last message is too old.

This screenshot should explain it:
qestimator1

I have a fix ready and will create a PR after tests.

@TSC21
Copy link
Member

TSC21 commented Feb 11, 2019

@ArkadiuszNiemiec a PR with a fix is welcomed, yes. Thanks

@ArkadiuszNiemiec
Copy link
Contributor Author

ArkadiuszNiemiec commented Feb 11, 2019

@TSC21 I have tested the #11437 in flight and it works perfectly. Here's the screenshot of the data generated in the same way as the previous one:
qestimator2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants