Remove goto statments, cleanup/tidying in tunes.cpp/h files. #11194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsauder
force-pushed
the
tunesWork
branch
5 times, most recently
from
7c8b3d2 to
8e2f50a
Compare
mcsauder
changed the title
mcsauder
force-pushed
the
tunesWork
branch
11 times, most recently
from
2217077 to
de24cff
Compare
mcsauder
force-pushed
the
tunesWork
branch
4 times, most recently
from
b3b1f29 to
1cb49c3
Compare
Closed
mcsauder
force-pushed
the
tunesWork
branch
5 times, most recently
from
ea6b2d5 to
08acb62
Compare
|
This seems fine to me as long as someone has thoroughly tested it. |
|
@mcsauder has this been tested on V2? |
|
@davids5 , yes, bench tested on pixhawk V2, pixracer V4, pixhawk 4 V5. |
|
Rebased on current master and re-tested on V2, V4, V5. |
davids5
previously approved these changes
Feb 5, 2019
mcsauder
force-pushed
the
tunesWork
branch
3 times, most recently
from
b4d0b84 to
54cb62e
Compare
…move a constructor overload by adding default values, and disambiguate a few variables by adding verbosity to naming.
dagar
approved these changes
Feb 11, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR removes a constructor overload by adding default values, performs a handful of variable initializations in tunes.h, replaces goto statements with method calls, and does a bit of formatting/housekeeping for readability.
This PR was bench tested on pixracer (fmu-v4) and pixhawk 4 (fmu-v5) hardware.
Let me know if you have any questions on this PR. Thanks!
-Mark