LPS22HB: Fix invalid driver reset (I2C bus) #11231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The driver was written for a board that has an lps22hb on spi. I was never able to actually test it on I2C. |
We have tested the driver on a copter with a custom board and a LPS22HB barometer on the I2C bus (primary barometer). The driver doesn't work correctly with I2C_DIS flag ("no baro sensor 0" error) and it's not possible to arm the vehicle. The vehicle arms and flies well with this commit. |
|
Ok, I'll verify the change on a board with an lps22hb on spi. |
dagar
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
Verified it's still working on SPI.
lps22hb_comms_errors: 0 events
lps22hb_read: 511 events, 9682us elapsed, 18.95us avg, min 17us max 78us 2.932us rms
nsh> listener sensor_baro
TOPIC: sensor_baro instance 0 #1
sensor_baro_s
timestamp: 33653416 (0.021898 seconds ago)
error_count: 0
device_id: 5767202 (Type: 0x58, SPI:4 (0x00))
pressure: 1023.3169
temperature: 47.4271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver sets I2C_DIS (I2C disable) flag during the reset. Reset operation will fail (on write_reg()) if the sensor is on the I2C bus. Driver works after a failed reset but doesn't create a BARO_BASE_DEVICE_PATH device file (/dev/baro*). It affects checks that use device files to determine a working barometer.
To fix the problem we should remove I2C_DIS flag from the driver's reset operation. Is there any reason why I2C_DIS flag has been added in the first place?