Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add script to set the correct ulimit on Mac OS #11247

Merged
merged 2 commits into from
Feb 5, 2019

Conversation

LorenzMeier
Copy link
Member

@LorenzMeier LorenzMeier commented Jan 20, 2019

This does not have automation yet.

Using call or shell or a direct call didn't work in the Makefile - likely because it is a different process group. Checking the user's bash config and appending if missing would be one way to do it (along with a bash restart).

This does not have automation yet.
@LorenzMeier
Copy link
Member Author

This fixes the "too many open files" error on Mac OS if you call this script once in the shell per session.

@dagar
Copy link
Member

dagar commented Jan 29, 2019

FYI @ryanjAA

@ryanjAA
Copy link
Contributor

ryanjAA commented Jan 30, 2019

I couldn’t get this to work with this script. I had to make several other changes (on any version of Mac OS >10.13) to increase both the number of open files and processes (processes probably not needed but done for good measure although both can have system performance concerns). Had to add two plist files to /Library/LaunchDaemons/ and then load them which also meant changing ownership of them to root:wheel After that though changing was easy and building was error free.

@dagar
Copy link
Member

dagar commented Feb 5, 2019

We might as well merge this until we have a more permanent/integrated solution.

@dagar dagar merged commit 3d3a98c into master Feb 5, 2019
@dagar dagar deleted the pr-mac-os-file-limit-fix branch February 5, 2019 15:19
@ryanjAA
Copy link
Contributor

ryanjAA commented Feb 5, 2019

This is what I ended up following to get it working. Ive seen a few more reports on slack of people having the issue and this is how I solved it:
https://wilsonmar.github.io/maximum-limits/

@LorenzMeier
Copy link
Member Author

@hamishwillee Could you please add this to the docs?

@hamishwillee
Copy link
Contributor

@LorenzMeier Sure, please check PX4/PX4-Devguide#748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants