micrortps_bridge: pass absolute path for yaml file and urtps templates #11253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Jan 21, 2019
|
@bkueng I addressed your comments. Can you please review again? Thanks! |
bkueng
reviewed
Jan 23, 2019
TSC21
force-pushed
the
feature/micrortps_bridge_pass_absolute_paths
branch
from
efb2c4c to
592c23f
Compare
|
@bkueng comments addressed. Thanks for reviewing! |
bkueng
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more flexibility for the scripts. Also a requirement for
px4_ros_comnew structure, where the .msg files are in a separate dir from the templates and the RTPS IDs yaml file.