Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HRT elapsed time update & atomic fix on IO #11283

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Jan 23, 2019

Follow-up to #11248.

  • inline hrt_elapsed_time
  • fix atomic access to system_state.fmu_data_received_time. This was an issue that already existed before.

GCC did not do that.
LorenzMeier
LorenzMeier previously approved these changes Jan 23, 2019
@dagar
Copy link
Member

dagar commented Jan 23, 2019

Minor px4iofirmware build failure.

image

system_state.fmu_data_received_time can be set from an IRQ handler, thus
we need to ensure every read access to it in mixer_tick is atomic.
So we read it once and copy it into a local variable.
@bkueng bkueng force-pushed the hrt_elapsed_time_update branch from a17fc11 to ec0c649 Compare January 24, 2019 07:08
@bkueng bkueng merged commit 3859bbb into master Jan 25, 2019
@bkueng bkueng deleted the hrt_elapsed_time_update branch January 25, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants