Fixing some typos, new-lines and headers #11292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
approved these changes
Jan 25, 2019
|
I agree with that view-point, although the longer term dream is still handling this type of feedback completely differently. |
|
Thanks for merging. "Differently" as in defining all messages outside of these classes in some centralized file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typos in comments, removed some new lines, corrected headers. Modified a few mavlink warning messages, but I understand that's a matter of taste.
In the future I would like to be more precise when we pint messages about sub-systems or safeguards and distinguish "enabled/disabled", "active/inactive" and "on/off". Enabled/Disabled sounds to me like a configuration, not a temporary state. "Failsafe mode disabled" sounds to me like it has been permanently disabled by parameter. The message suggests that a setting was modified.
It's the same thing with driving assistance functions in cars: ABS, ESC and Traction Control can be enabled without being active. But when enabled and if necessary, these systems will become active on their own.
If the community agrees with this view-point, I can go through other mavlink messages and modify some more.