-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fw_pos_control_l1 add new simple min groundspeed #11381
Conversation
8d73f01
to
99bc955
Compare
Makes sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this looks correct.
We should be able to test this effectively in SITL, although a real flight never hurts. |
happy to flight test. might not be until next week based on weather here this week. |
99bc955
to
0a5003c
Compare
0a5003c
to
9ee3655
Compare
Flight tested successfully. We set FW_GND_SPD_MIN very low (1 m/s) and see that the airspeed remains very steady even when flying into a headwind where it would previously have increased airspeed such that ground speed >= fw_airspd_min (14.3 m/s in our case). You can see ground speed is allowed to go below 14.3 m/s in our log. We believe this is working correctly. Flight log: |
Been flying this a lot lately. Works great and improves flight control in windy conditions. Would be nice if it made in into Master IMHO. |
Needs a squash and merge. |
This would be good to get in for v1.10. Been flying a version of it successfully for several months, 100's of flights. |
@dagar I think this is good to go? we've been flying it a lot lately and it works as intended. |
@Antiheavy Could you ping me on any other PRs in similar states that really should go in? |
This introduces a new FW parameter
FW_GND_SPD_MIN
to set the desired minimum groundspeed. This replaces existing logic which projects your current airspeed to the ground and has weird coupling with large pitch changes.Fixes #10078