Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fw_pos_control_l1 add new simple min groundspeed #11381

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Feb 5, 2019

This introduces a new FW parameter FW_GND_SPD_MIN to set the desired minimum groundspeed. This replaces existing logic which projects your current airspeed to the ground and has weird coupling with large pitch changes.

Fixes #10078

LorenzMeier
LorenzMeier previously approved these changes Feb 5, 2019
@LorenzMeier
Copy link
Member

Makes sense

Antiheavy
Antiheavy previously approved these changes Feb 6, 2019
Copy link
Contributor

@Antiheavy Antiheavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this looks correct.

@dagar
Copy link
Member Author

dagar commented Feb 6, 2019

We should be able to test this effectively in SITL, although a real flight never hurts.

@Antiheavy
Copy link
Contributor

We should be able to test this effectively in SITL, although a real flight never hurts.

happy to flight test. might not be until next week based on weather here this week.

@dagar dagar force-pushed the pr-fw_min_gndspeed branch from 0a5003c to 9ee3655 Compare March 13, 2019 14:34
@Antiheavy
Copy link
Contributor

Antiheavy commented May 25, 2019

Flight tested successfully. We set FW_GND_SPD_MIN very low (1 m/s) and see that the airspeed remains very steady even when flying into a headwind where it would previously have increased airspeed such that ground speed >= fw_airspd_min (14.3 m/s in our case). You can see ground speed is allowed to go below 14.3 m/s in our log. We believe this is working correctly.

Flight log:
https://review.px4.io/plot_app?log=7113bba3-2e45-4b01-8d59-a97ea66e93f7

image

@Antiheavy
Copy link
Contributor

Been flying this a lot lately. Works great and improves flight control in windy conditions. Would be nice if it made in into Master IMHO.

@LorenzMeier
Copy link
Member

Needs a squash and merge.

@Antiheavy
Copy link
Contributor

Antiheavy commented Jul 14, 2019

This would be good to get in for v1.10. Been flying a version of it successfully for several months, 100's of flights.

@Antiheavy
Copy link
Contributor

@dagar I think this is good to go? we've been flying it a lot lately and it works as intended.

@LorenzMeier LorenzMeier merged commit e43e37c into PX4:master Aug 7, 2019
@LorenzMeier
Copy link
Member

@Antiheavy Could you ping me on any other PRs in similar states that really should go in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: improved minimum ground speed controller for Fixed Wing
3 participants