Whitespace formatting in mavlink_main.cpp/h and begin migrating variable initialization. #11608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsauder
force-pushed
the
mavlink_main_var_initialization_part_2
branch
2 times, most recently
from
57d1dd2 to
dfb468a
Compare
dagar
reviewed
Mar 9, 2019
| */ | ||
| int get_component_id() const { return mavlink_system.compid; } | ||
|
|
||
| const char *_device_name; | ||
| const char *_device_name{DEFAULT_DEVICE_NAME}; |
There was a problem hiding this comment.
Isn't this still set in the constructor?
There was a problem hiding this comment.
I left the inits in the constructor in this PR to make the diff a little simpler. I relalize that it's repetitively redundant at the moment but I was aiming to keep the diff as easy as possible to verify the values in this PR. I can deprecate as I migrate, give me a minute and I'll have that pushed up.
There was a problem hiding this comment.
The vars that are initialized at declaration in this PR are no longer in the constructor list. Thanks for your review!
…riable initialization at declaration in mavlink_main.h.
mcsauder
force-pushed
the
mavlink_main_var_initialization_part_2
branch
from
dfb468a to
bce9d05
Compare
dagar
approved these changes
Mar 9, 2019
|
Thanks @dagar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
This PR continues work started in PR #11580 to cleanup formatting in mavlink_main.cpp/h and migrate variable initialization from the Mavlink class constructor list to the variable declarations. This PR is predominantly whitespace changes with only a few var initialization instances added into mavlink_main.h. Additional step-by-step work will follow this PR to complete the migration.
Additional context
This work was started in PR #11580.
Please let me know if you have any questions on this PR. Thanks!
-Mark