removed non used _getMaxCruiseSpeed #11615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzMeier
reviewed
Mar 10, 2019
| @@ -87,7 +87,6 @@ class FlightTaskAuto : public FlightTask | |||
|
|
|||
| protected: | |||
| void _setDefaultConstraints() override; | |||
| float _getMaxCruiseSpeed() {return MPC_XY_CRUISE.get();} /**< getter for default cruise speed */ | |||
There was a problem hiding this comment.
@LorenzMeier in this point there is still dead code that can be removed.
you might want to refer your question to this point of the code:
https://github.com/PX4/Firmware/blob/1638a1cb45c18cd6f4af89bee58b8dd2b30f8c51/src/lib/FlightTasks/tasks/Auto/FlightTaskAuto.cpp#L409
I am more than agree that the param abstraction mechanism must be more real-time oriented, than "code simplicity" oriented
There was a problem hiding this comment.
@LorenzMeier it's ultimately the same access pattern. This is all inlined.
https://github.com/PX4/Firmware/blob/a9fc04b2f9ebc0cd48888c62a9c4fdd9beb77504/src/platforms/px4_param.h#L157
dagar
approved these changes
Mar 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as part of doing some cleanups of parameters related code, this line has jumped, as a dead code that can be removed.
in order to '_getMaxCruiseSpeed' we can just use MPC_XY_CRUISE.get()