-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iris benchmarking #11626
Add iris benchmarking #11626
Conversation
Hi Nico, is this "generically" for benchmarking - ie this will be used for all benchmarking, or is it "benchmarking for obstacle avoidance". If the later, perhaps worth being more specific in names and docs - ie 1015_iris_avoidance_benchmarking or 1015_iris_avoidance_reference |
Well, yeah, I'm not going to tell anyone how to use it or not. But I'm using it to benchmark obstacle avoidance. I'll rename it if you prefer, no biggie |
8707f4d
to
0e88e01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicovanduijn this is a question out of curiosity on how your setup works: the iris model doesn't have s depth sensor. Where do you get the depth data from?
if [ $AUTOCNF = yes ] | ||
then | ||
param set COM_OBS_AVOID 1 # enable obstacle avoidance | ||
param set MPC_XY_CRUISE 5.0 # set maximum mission speed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This iris configuration is super similar to the one introduced here #10780 . I think we can unify them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm attaching the depth sensor later in the actual benchmarking vehicle. Reason being that different avoidance algorithms might require different sensors to function, and I want to be able to compare them.
We can unify of course, just don't forget about the mavlink stream and the additions in Tools/sitl_gazebo
What is the value of this model upstream? |
The benchmarking suite will be public soon, and thus needs to work with upstream |
Just FYI this was more of a question - I don't know whether this is/was generally useful for benchmarking or has specific constraints that make it suitable for only specific cases. If the former then the old name was good. If the later, then the name should reflect the constraints. |
Actually, I think I'm going to build on top of the model Martina just introduced - in order not to clutter the repository with a thousand vehicles. Thus, it will be called |
0e88e01
to
757ff7d
Compare
This updates the submodule sitl_gazebo to include the iris_obs_avoid sdf model
61dc8e9
to
99769b3
Compare
@mrivi Any thoughts now that the submodule is in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds the necessary SITL setup files for a new simulation vehicle used for benchmarking of Obstacle Avoidance.
Main difference to the regular
Iris
is an additional MAVLink stream, which is needed in order to be able to use both MAVROS and the SDK.Depends on PX4/PX4-SITL_gazebo-classic#300