Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iris benchmarking #11626

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Add iris benchmarking #11626

merged 2 commits into from
Apr 2, 2019

Conversation

nicovanduijn
Copy link
Contributor

@nicovanduijn nicovanduijn commented Mar 12, 2019

This PR adds the necessary SITL setup files for a new simulation vehicle used for benchmarking of Obstacle Avoidance.

Main difference to the regular Iris is an additional MAVLink stream, which is needed in order to be able to use both MAVROS and the SDK.

Depends on PX4/PX4-SITL_gazebo-classic#300

@hamishwillee
Copy link
Contributor

Hi Nico, is this "generically" for benchmarking - ie this will be used for all benchmarking, or is it "benchmarking for obstacle avoidance". If the later, perhaps worth being more specific in names and docs - ie 1015_iris_avoidance_benchmarking or 1015_iris_avoidance_reference

@nicovanduijn
Copy link
Contributor Author

Well, yeah, I'm not going to tell anyone how to use it or not. But I'm using it to benchmark obstacle avoidance.

I'll rename it if you prefer, no biggie

@nicovanduijn nicovanduijn force-pushed the add-iris-benchmarking branch from 8707f4d to 0e88e01 Compare March 13, 2019 13:45
Copy link
Contributor

@mrivi mrivi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicovanduijn this is a question out of curiosity on how your setup works: the iris model doesn't have s depth sensor. Where do you get the depth data from?

if [ $AUTOCNF = yes ]
then
param set COM_OBS_AVOID 1 # enable obstacle avoidance
param set MPC_XY_CRUISE 5.0 # set maximum mission speed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This iris configuration is super similar to the one introduced here #10780 . I think we can unify them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm attaching the depth sensor later in the actual benchmarking vehicle. Reason being that different avoidance algorithms might require different sensors to function, and I want to be able to compare them.

We can unify of course, just don't forget about the mavlink stream and the additions in Tools/sitl_gazebo

@mhkabir
Copy link
Member

mhkabir commented Mar 13, 2019

Well, yeah, I'm not going to tell anyone how to use it or not.

What is the value of this model upstream?

@nicovanduijn
Copy link
Contributor Author

What is the value of this model upstream?

The benchmarking suite will be public soon, and thus needs to work with upstream

@hamishwillee
Copy link
Contributor

Well, yeah, I'm not going to tell anyone how to use it or not. But I'm using it to benchmark obstacle avoidance.

Just FYI this was more of a question - I don't know whether this is/was generally useful for benchmarking or has specific constraints that make it suitable for only specific cases. If the former then the old name was good. If the later, then the name should reflect the constraints.

@nicovanduijn
Copy link
Contributor Author

Actually, I think I'm going to build on top of the model Martina just introduced - in order not to clutter the repository with a thousand vehicles. Thus, it will be called iris_obs_avoid - which is a bit more general. Are you fine with that?

@nicovanduijn nicovanduijn force-pushed the add-iris-benchmarking branch from 0e88e01 to 757ff7d Compare March 15, 2019 11:06
Nico van Duijn added 2 commits March 27, 2019 08:05
This updates the submodule sitl_gazebo to include the iris_obs_avoid
sdf model
@nicovanduijn nicovanduijn force-pushed the add-iris-benchmarking branch from 61dc8e9 to 99769b3 Compare March 27, 2019 07:07
@nicovanduijn nicovanduijn changed the title [WIP] Add iris benchmarking Add iris benchmarking Mar 27, 2019
@nicovanduijn
Copy link
Contributor Author

@mrivi Any thoughts now that the submodule is in?

Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge from my side. Anything else @mrivi @mhkabir?

@bkueng bkueng merged commit 0b548fa into PX4:master Apr 2, 2019
@nicovanduijn nicovanduijn deleted the add-iris-benchmarking branch April 2, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants