-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ecl library version with recent bug fixes and enhancements. #11630
Conversation
Additional testing required? |
Reversion testing with FW and MC platforms is recommended. Individual bugfix changes have been tested, but not flown as a complete package. |
Build is failing - will investigate and fix. |
@priseborough we seem to have some trouble regarding #11092 - which brings usage to PX4/PX4-ECL#543. |
@TSC21 I will add the minimum changes to ekf2_main to handle the revised access to the state variances. |
c33438f
to
0a4050c
Compare
@dagar and @tstellanova, PX4/PX4-ECL#588 appears to be causing the CI SITL ecl data validation tests to fail. |
Bug Fixes: PX4/PX4-ECL#586 - EKF: fix covariance and output filter buffer initialization PX4/PX4-ECL#590 - EKF: Fix innovation in fuseDeclination() Enhancements: PX4/PX4-ECL#543 - ekf_helper: add more useful methods to interface with the covariances PX4/PX4-ECL#588 - Add unit tests for DataValidator Note: PX4/PX4-ECL#543 has required a change to how the state variances are accessed .
Should be fixed now. |
Tested on Pixracer v4;
https://review.px4.io/plot_app?log=2ff0d9b0-58c5-4e2d-9993-2883e2d1fe7f |
Tested on Pixhawk 4 v5; no issues were noted, good flight in general. Tested on Pixhawk 4mini v5; no issues were noted, good flight in general. |
Tested on Pixhawk cube v2;
https://review.px4.io/plot_app?log=27081981-026b-4c64-804a-cbad637f821e |
@priseborough Sound like issues persist here. |
@jorge789 Your crash had nothing to do with the estimator. Innovations were within limits throughout. Edit: Log finishes with no sign of abnormality when vehicle is flying so it looks like the autopilot shutdown/rebooted. Note that there was a battery voltage warning and voltage is dropping rapidly just before the log stops, eg: CPU Load is stable and there are no other warning messages: |
I'm not seeing an obvious issue in this log. Did your battery die? Is your power module (current/voltage sensor) calibrated? https://docs.px4.io/en/config/battery.html https://review.px4.io/plot_app?log=2ff0d9b0-58c5-4e2d-9993-2883e2d1fe7f#Nav-Power |
Bug Fixes:
PX4/PX4-ECL#586 - EKF: fix covariance and output filter buffer initialization
PX4/PX4-ECL#590 - EKF: Fix innovation in fuseDeclination()
Enhancements:
PX4/PX4-ECL#543 - ekf_helper: add more useful methods to interface with the covariances
PX4/PX4-ECL#588 - Add unit tests for DataValidator