Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ecl library version with recent bug fixes and enhancements. #11630

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

priseborough
Copy link
Contributor

@priseborough priseborough commented Mar 12, 2019

Bug Fixes:

PX4/PX4-ECL#586 - EKF: fix covariance and output filter buffer initialization
PX4/PX4-ECL#590 - EKF: Fix innovation in fuseDeclination()

Enhancements:

PX4/PX4-ECL#543 - ekf_helper: add more useful methods to interface with the covariances
PX4/PX4-ECL#588 - Add unit tests for DataValidator

@priseborough priseborough requested a review from RomanBapst March 12, 2019 21:29
@priseborough priseborough self-assigned this Mar 12, 2019
@priseborough priseborough added this to the Release v1.9.0 milestone Mar 12, 2019
@dagar
Copy link
Member

dagar commented Mar 12, 2019

Additional testing required?

@priseborough
Copy link
Contributor Author

Reversion testing with FW and MC platforms is recommended. Individual bugfix changes have been tested, but not flown as a complete package.

@priseborough
Copy link
Contributor Author

Build is failing - will investigate and fix.

@TSC21
Copy link
Member

TSC21 commented Mar 12, 2019

@priseborough we seem to have some trouble regarding #11092 - which brings usage to PX4/PX4-ECL#543.

@priseborough
Copy link
Contributor Author

@TSC21 I will add the minimum changes to ekf2_main to handle the revised access to the state variances.

@priseborough
Copy link
Contributor Author

@dagar and @tstellanova, PX4/PX4-ECL#588 appears to be causing the CI SITL ecl data validation tests to fail.

@priseborough
Copy link
Contributor Author

priseborough commented Mar 12, 2019

Short flight on a multi-rotor (pixhawk cube) showed no issues with estimator performance or CPU load:

CPU Load:
Screen Shot 2019-03-13 at 10 35 22 am

Estimator time slip:
Screen Shot 2019-03-13 at 10 31 48 am

Magnetomer:
Screen Shot 2019-03-13 at 10 24 31 am

GPs velocity:
Screen Shot 2019-03-13 at 10 25 04 am

GPS Position:
Screen Shot 2019-03-13 at 10 25 52 am

Baro:
Screen Shot 2019-03-13 at 10 26 32 am

Quaternion variances:
Screen Shot 2019-03-13 at 10 28 01 am

Quaternion Reset Count:
Screen Shot 2019-03-13 at 10 29 02 am

Bug Fixes:

PX4/PX4-ECL#586 - EKF: fix covariance and output filter buffer initialization
PX4/PX4-ECL#590 - EKF: Fix innovation in fuseDeclination()

Enhancements:

PX4/PX4-ECL#543 - ekf_helper: add more useful methods to interface with the covariances
PX4/PX4-ECL#588 - Add unit tests for DataValidator

Note:

PX4/PX4-ECL#543  has required a change to how the state variances are accessed .
@dagar dagar force-pushed the pr-ekf2BugFixes branch from 0a4050c to d10e386 Compare March 13, 2019 03:30
@dagar
Copy link
Member

dagar commented Mar 13, 2019

Should be fixed now.

@dagar dagar requested a review from a team March 13, 2019 14:07
@jorge789
Copy link

jorge789 commented Mar 13, 2019

Tested on Pixracer v4;

  • Armed.
  • Takeoff on position mode and flew as expected.
  • Switched to altitude mode, a few seconds later vehicle made flipped and collapsed.

https://review.px4.io/plot_app?log=2ff0d9b0-58c5-4e2d-9993-2883e2d1fe7f

@Junkim3DR
Copy link

Tested on Pixhawk 4 v5; no issues were noted, good flight in general.
https://review.px4.io/plot_app?log=e0b0dbb2-c743-445e-a1fc-e17bc89c3d42
Master was tested as well; no noticeable differences.
https://review.px4.io/plot_app?log=c3e08940-4078-466e-aff1-853e28aad108

Tested on Pixhawk 4mini v5; no issues were noted, good flight in general.
https://review.px4.io/plot_app?log=dc3b8978-3879-4e5c-9f76-f059558fa7e7
Master was tested as well; no noticeable differences.
https://review.px4.io/plot_app?log=a6268987-ab5c-4d87-8bbf-e503b30964f1

@jorge789
Copy link

jorge789 commented Mar 13, 2019

Tested on Pixhawk cube v2;

  • Position, Altitude, Stabilized, Mission, RTL modes tested, no issues were noted during flight.
    Good flight in general.

https://review.px4.io/plot_app?log=27081981-026b-4c64-804a-cbad637f821e

@LorenzMeier
Copy link
Member

@priseborough Sound like issues persist here.

@priseborough
Copy link
Contributor Author

priseborough commented Mar 13, 2019

@jorge789 Your crash had nothing to do with the estimator. Innovations were within limits throughout.

Edit: Log finishes with no sign of abnormality when vehicle is flying so it looks like the autopilot shutdown/rebooted. Note that there was a battery voltage warning and voltage is dropping rapidly just before the log stops, eg:

Screen Shot 2019-03-14 at 10 01 42 am

CPU Load is stable and there are no other warning messages:

Screen Shot 2019-03-14 at 10 03 49 am

@dagar
Copy link
Member

dagar commented Mar 14, 2019

Tested on Pixracer v4;

  • Armed.
  • Takeoff on position mode and flew as expected.
  • Switched to altitude mode, a few seconds later vehicle made flipped and collapsed.

https://review.px4.io/plot_app?log=2ff0d9b0-58c5-4e2d-9993-2883e2d1fe7f

I'm not seeing an obvious issue in this log. Did your battery die? Is your power module (current/voltage sensor) calibrated? https://docs.px4.io/en/config/battery.html

https://review.px4.io/plot_app?log=2ff0d9b0-58c5-4e2d-9993-2883e2d1fe7f#Nav-Power

image

@priseborough priseborough merged commit f8ae8ba into PX4:master Mar 14, 2019
@priseborough priseborough deleted the pr-ekf2BugFixes branch January 25, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants