Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trajectory generator-based FlightTasks - Handle position and velocity resets from EKF #11637

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

bresch
Copy link
Member

@bresch bresch commented Mar 13, 2019

So far, only the XY position reset was properly handled to avoid position jumps during an EKF reset (GPS regained for example). This PR also takes care about the Z axis and all the velocities resets.

Needs #11636 to show the real improvement.

bresch added 2 commits March 13, 2019 11:42
… the trajectories in case of EKF reset. Until now, only the position reset on XY axis was properly handled. Now, xy, vxy, z and vz are handled
@bresch bresch requested a review from bkueng March 13, 2019 11:27
@dagar dagar requested a review from a team March 13, 2019 17:00
@bresch
Copy link
Member Author

bresch commented Mar 13, 2019

@PX4/testflights please test this PR with a multicopter and the following parameter:
MPC_POS_MODE = 3 (Smooth Vel)
We need to test that both in manual position control and in mission.
Thanks!

@jorge789
Copy link

Tested on Pixhawk v2 cube; The MPC_POS_MODE parameter was changed to Smooth position control (velocity). It took off in position, but there was a delay between the RC commands and the vehicle response; note that this issue was only present during Position Mode.

In altitude, Stabilized, Mission and RTL modes vehicle flew as expected.

https://review.px4.io/plot_app?log=83f6e61d-3fa6-4b4f-9c52-1b12604e1af8

@Junkim3DR
Copy link

Junkim3DR commented Mar 15, 2019

Tested on Pixhawk 4 v5; no issues were noted, good flight in general.

Parameter tested:

  • MPC_POS_MODE to Smooth Position Control (Velocity).

https://review.px4.io/plot_app?log=4bf45cbe-6658-4fbd-913e-a4a0cdac519c#Nav-Local-Position-Y

Copy link

@Tony3dr Tony3dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Pixhawk 4 v5 & Pixhawk v2 cube
slight delay in commands and the vehicle response in Position Mode for the V2. Other than that the vehicle flew as expected, good flights overall.

@bresch
Copy link
Member Author

bresch commented Mar 20, 2019

Thanks @jorge789 , @Junkim3DR and @Tony3dr .

I checked the log files:
On v2:
MPC_ACC_HOR_MAX = 2.5
MPC_JERK_MAX = 2

On v5:
MPC_ACC_HOR_MAX = 10
MPC_JERK_MAX = 20

So it makes sense that the response is slower on the V2.

@dagar Can we merge that PR?

@dagar
Copy link
Member

dagar commented Mar 20, 2019

Thanks everyone, let's get this in.

@dagar dagar merged commit a08b168 into master Mar 20, 2019
@dagar dagar deleted the pr-ekfreset branch March 20, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants