-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trajectory generator-based FlightTasks - Handle position and velocity resets from EKF #11637
Conversation
…case to camelCase
… the trajectories in case of EKF reset. Until now, only the position reset on XY axis was properly handled. Now, xy, vxy, z and vz are handled
@PX4/testflights please test this PR with a multicopter and the following parameter: |
Tested on Pixhawk v2 cube; The MPC_POS_MODE parameter was changed to Smooth position control (velocity). It took off in position, but there was a delay between the RC commands and the vehicle response; note that this issue was only present during Position Mode. In altitude, Stabilized, Mission and RTL modes vehicle flew as expected. https://review.px4.io/plot_app?log=83f6e61d-3fa6-4b4f-9c52-1b12604e1af8 |
Tested on Pixhawk 4 v5; no issues were noted, good flight in general. Parameter tested:
https://review.px4.io/plot_app?log=4bf45cbe-6658-4fbd-913e-a4a0cdac519c#Nav-Local-Position-Y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Pixhawk 4 v5 & Pixhawk v2 cube
slight delay in commands and the vehicle response in Position Mode for the V2. Other than that the vehicle flew as expected, good flights overall.
Thanks @jorge789 , @Junkim3DR and @Tony3dr . I checked the log files: On v5: So it makes sense that the response is slower on the V2. @dagar Can we merge that PR? |
Thanks everyone, let's get this in. |
So far, only the XY position reset was properly handled to avoid position jumps during an EKF reset (GPS regained for example). This PR also takes care about the Z axis and all the velocities resets.
Needs #11636 to show the real improvement.