Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc_pos_control limit to 50 Hz #11639

Merged
merged 1 commit into from
Mar 15, 2019
Merged

mc_pos_control limit to 50 Hz #11639

merged 1 commit into from
Mar 15, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Mar 13, 2019

@dagar dagar requested a review from a team March 13, 2019 15:06
Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my past experience with other multicopter flight control software 50Hz update frequency is sufficient for the position control loop and should not impose any performance impact. But we need to test this carefully to make sure there are no side effects in the current implementation.

@Junkim3DR
Copy link

Tested on Pixhawk 4 v5; no issues were noted, good flight in general.
https://review.px4.io/plot_app?log=a5db1a1c-644f-43bf-acf5-390844fc685d
Master was tested as well; no noticeable differences.
https://review.px4.io/plot_app?log=c3e08940-4078-466e-aff1-853e28aad108

Tested on Pixhawk 4mini v5; no issues were noted, good flight in general.
https://review.px4.io/plot_app?log=2c918d21-88e7-4932-9ee3-c440b8200646
Master was tested as well; no noticeable differences.
https://review.px4.io/plot_app?log=a6268987-ab5c-4d87-8bbf-e503b30964f1

@jorge789
Copy link

Tested on Pixhawk cube v2;
It was tested in all modes Position, Altitude, Stabilized, Mission and RTL and it works very well in all modes.
Note;
It was compared with mater and no noticeable change was seen, but it went well.

FLIGHT (PR11639)
https://review.px4.io/plot_app?log=b5d31c42-f989-485d-846e-d3c3d06138f5

FLIGHT IN MASTER (COMPARISON)
https://review.px4.io/plot_app?log=69241f72-179d-4095-9a32-a22e9c371875

Copy link

@Tony3dr Tony3dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on V2 & V5 no noticeable issues. All flights were successful.

@dagar dagar merged commit 1083af2 into master Mar 15, 2019
@dagar dagar deleted the pr-mc_pos_ctrl_rate branch March 15, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants