perf convert to c++ and enable -Wcast-align #11641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-perf_cleanup
branch
3 times, most recently
from
d36df47 to
6b5e5a0
Compare
dagar
changed the title
julianoes
reviewed
Mar 15, 2019
There was a problem hiding this comment.
I added one question, otherwise looks good.
I didn't know about this warning and just read about it here: http://blog.antiblau.de/2016/07/13/cc-developers-please-use-wcast-align/
Why did this come up? Is it just general precaution or was there a bug because of it?
Mostly paranoia over potential alignment issues on arm after #11408. |
julianoes
previously approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.