Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lockstep_scheduler: check if mutex is still valid #11655

Merged
merged 1 commit into from
Mar 15, 2019
Merged

lockstep_scheduler: check if mutex is still valid #11655

merged 1 commit into from
Mar 15, 2019

Conversation

julianoes
Copy link
Contributor

@julianoes julianoes commented Mar 15, 2019 •
edited by AuterionWrikeBot
Loading

It turns out that we can fix the unit tests of the lockstep_scheduler just by checking if passed_lock is not nullptr.

Without this check, the unit tests segfaulted.

@julianoes
lockstep_scheduler: check if mutex is still valid
1a13748 
It turns out that we can fix the unit tests of the lockstep_scheduler
just by checking if `passed_lock` is not `nullptr`.

Without this check, the unit tests segfaulted.
@julianoes julianoes requested a review from bkueng March 15, 2019 12:17
bkueng
bkueng approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julianoes

@bkueng bkueng merged commit b54ca67 into master Mar 15, 2019
@bkueng bkueng deleted the fix-lockstep-unittest branch March 15, 2019 12:38
@mrpollo mrpollo mentioned this pull request Apr 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkueng bkueng bkueng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianoes @bkueng