Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added aux6 RC channel #11723

Merged
merged 1 commit into from
Apr 3, 2019
Merged

added aux6 RC channel #11723

merged 1 commit into from
Apr 3, 2019

Conversation

RomanBapst
Copy link
Contributor

Added support for a 6th pass-through channel.

LorenzMeier
LorenzMeier requested changes Mar 26, 2019
View reviewed changes
Copy link
Member

@LorenzMeier LorenzMeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving everything up by one can lead to unexpected mismatches on existing setups. I think it’s better if you just amend the new channel.

@RomanBapst
Copy link
Contributor Author

@LorenzMeier We convinced ourselves that this should not happen, but I still agree with you.
Better be safe.

@RomanBapst
added aux6 RC channel
991d6e5 
Signed-off-by: Roman <bapstroman@gmail.com>
@RomanBapst RomanBapst requested a review from dagar April 2, 2019 20:11
@dagar
Copy link
Member

dagar commented Apr 2, 2019

Looks right. What testing have you done?

@RomanBapst
Copy link
Contributor Author

@dagar Tested on a daily basis with multiple vehicles.

@dagar dagar merged commit d36c0e1 into master Apr 3, 2019
@dagar dagar deleted the pr-aux6 branch April 3, 2019 12:23
@mrpollo mrpollo mentioned this pull request Apr 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzMeier LorenzMeier LorenzMeier requested changes

@dagar dagar dagar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomanBapst @dagar @LorenzMeier