init.d-posix: re-use rc.logging #11790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change the param SDLOG_MODE can be used for SITL as well.
Right, we have it for others as well, like SYS_USE_IO. Maybe change the log level to info? |
Let me check how it's done. |
This prevents a warning message being printed to SITL users because the UAVCAN_ENABLE param does not exist.
bkueng
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the param SDLOG_MODE can be used for SITL as well.
Fixes #11774
The only caveat with this change is that we see this on startup, @bkueng any idea what to do about it?