Standardising mavlink message strings #11796
Conversation
| @@ -1038,7 +1038,7 @@ Commander::handle_command(vehicle_status_s *status_local, const vehicle_command_ | |||
| // if no high latency telemetry exists send a failed acknowledge | |||
| if (_high_latency_datalink_heartbeat > commander_boot_timestamp) { | |||
| cmd_result = vehicle_command_s::VEHICLE_CMD_RESULT_FAILED; | |||
| mavlink_log_critical(&mavlink_log_pub, "Control high latency failed, no hl telemetry available"); | |||
There was a problem hiding this comment.
This guy exceeded 50 characters before the change.
src/modules/commander/Commander.cpp
Outdated
| @@ -2118,7 +2118,7 @@ Commander::run() | |||
|
|
|||
| } else { | |||
| if (!status_flags.rc_input_blocked && !status.rc_signal_lost) { | |||
| mavlink_log_critical(&mavlink_log_pub, "MANUAL CONTROL LOST (at t=%" PRIu64 "ms)", hrt_absolute_time() / 1000); | |||
| mavlink_log_critical(&mavlink_log_pub, "Manual control lost (at t=%" PRIu64 "ms)", hrt_absolute_time() / 1000); | |||
There was a problem hiding this comment.
In my opinion we should remove the timestamp here.
There was a problem hiding this comment.
Fine by me. I always wondered why this message should be exceptional 😅
src/modules/commander/Commander.cpp
Outdated
| } | ||
|
|
||
| if (_datalink_last_status_avoidance_system == telemetry_status_s::MAV_STATE_FLIGHT_TERMINATION) { | ||
| mavlink_log_critical(&mavlink_log_pub, "Avoidance system abort"); | ||
| mavlink_log_critical(&mavlink_log_pub, "Avoidance system aborted"); |
There was a problem hiding this comment.
@mrivi I assume you know this: What's the meaning of aborted here? Is autonomous flight terminated and the flight controller stops listening to obstacle avoidance? Or is something wrong with the obstacle avoidance? I assume it's the former and not the latter. :)
There was a problem hiding this comment.
It means that there is something wrong with the avoidance and the vehicle doesn't accept anymore any setpoint from the OA system
There was a problem hiding this comment.
Should we then say "Avoidance system rejected" ?
|
Late to the party. This is great! |
|
Thanks @hamishwillee 😁 |
I tried to standardise the mavlink message strings a tiny bit:
I understand that this is a matter of taste to some extent, but let's see :)