Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup - removed duplicate const MAX_ACTUATORS definition #12462

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

BazookaJoe1900
Copy link
Member

There are two dupliacate const definitions, one global and one in the class, which is singletone anyway.
The definition is duplicated to _max_actuators

@dagar
Copy link
Member

dagar commented Jul 11, 2019

Keep the upper case naming for a constant? MAX_ACTUATORS

@BazookaJoe1900 BazookaJoe1900 force-pushed the pr-clean_up_max_actuators branch from 305cb49 to 7733a05 Compare July 11, 2019 15:30
@dagar
Copy link
Member

dagar commented Jul 11, 2019

Hmm, upper case with underscore doesn't look quite right, but let's go with it for now.
This is probably a good example of why we need a coding standard for naming constants, member variables, etc.

Thanks @BazookaJoe1900

@dagar
Copy link
Member

dagar commented Jul 11, 2019

@BazookaJoe1900
Copy link
Member Author

Sorry about the bad coding standard.. I was rushing doing the pr.
I will fix that.... but in two days. Wait with the marging

@dagar
Copy link
Member

dagar commented Jul 11, 2019

No need to apologize, the problem is there's no (written) coding standard

@dagar
Copy link
Member

dagar commented Jul 11, 2019

It's still nice to get rid of the duplication and easy to change later. Thanks again.

@dagar dagar merged commit 7be5d15 into PX4:master Jul 11, 2019
@BazookaJoe1900 BazookaJoe1900 deleted the pr-clean_up_max_actuators branch July 15, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants