Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix airframes incremental build #12525

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Conversation

jlecoeur
Copy link
Contributor

Describe problem solved by the proposed pull request
Incremental build was not triggered when an airframe startup script, or one of the python scripts used to parse it, was modified.

Describe your preferred solution
Let cmake know about these files.

Additional context
To test:

  • build
  • modify ROMFS/px4fmu_common/init.d/airframes/4001_quad_x
  • re build

Before this PR: nothing happens
With this PR: incremental build

@jlecoeur jlecoeur requested review from dagar and bkueng July 20, 2019 17:43
@jlecoeur jlecoeur added bug Tools Sub-tools used within PX4 ecosystem (scripts, etc) labels Jul 20, 2019
Copy link
Contributor

@dakejahl dakejahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha about time someone did this 😁

@julianoes julianoes merged commit 8f47535 into master Jul 24, 2019
@julianoes julianoes deleted the pr-airframes_incremental_build branch July 24, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Tools Sub-tools used within PX4 ecosystem (scripts, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants